Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

refactor: remove debian10/Dockerfile and update CONTRIBUTING #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
repo-ranger merged 2 commits into main from jsjoeio/remove-dev-dockerfile
Apr 14, 2021

Conversation

@jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Apr 14, 2021 •
edited
Loading

This PR removed debian10/Dockerfile which was introduced orignally by moog in #1499 for Docker development.

It also updates the CONTRIBUTING.md file with global module/packages required for developing code-server.

Originally discussed here noting that we no longer use or need to maintain this.
#3077 (review)

@jsjoeio jsjoeio self-assigned this Apr 14, 2021
@jsjoeio jsjoeio marked this pull request as ready for review April 14, 2021 23:24
@jsjoeio jsjoeio requested a review from a team as a code owner April 14, 2021 23:24
Copy link

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having docker images to make development environments reproducible/easier to set up for new contributors, though an unmaintained image is worse than not having one, so this makes sense to me 😄 I think for the future we should revisit this, maybe we could make an image to do code-server development inside code-server, and also a variant for code-server development inside coder.

jsjoeio reacted with heart emoji
Copy link
Contributor Author

jsjoeio commented Apr 14, 2021

Love that idea! Noted for future in #2818 :D

@repo-ranger repo-ranger bot merged commit a05c4e4 into main Apr 14, 2021
@repo-ranger repo-ranger bot deleted the jsjoeio/remove-dev-dockerfile branch April 14, 2021 23:59
Copy link

oxy commented Apr 16, 2021

Uh oh - we still use the debian10 image in our release workflow, and our custom centos7 image is actually unused; I'll work on removing the dependency on the debian10 image in our workflow before we make a release 😅
jsjoeio reacted with thumbs up emoji jsjoeio reacted with laugh emoji

@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jawnsy jawnsy jawnsy approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

chore Related to maintenance or clean up

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /