-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Integrate Coder Cloud Agent #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It would be interesting to see this on gitlab too. Might be a better value, than competing against github.
This might be prone to name collisions as there might be cases you'll want to run it on a seperate system should they choose not to use a container - we should add at least a randomized identifier which is how Codespaces has done it.
This might be prone to name collisions as there might be cases you'll want to run it on a seperate system should they choose not to use a container - we should add at least a randomized identifier which is how Codespaces has done it.
You get to pick the name every time. We'd rather have a short URL. If there is a conflict, we can append some random text to the name ourselves @sreya
As @nhooyr said you get to pick the name everytime you register a new server, the names won't conflict across different users because it is a unique key composed of the server name and your github username. For now as a user, you cannot register two servers with the same name.
It would be interesting to see this on gitlab too. Might be a better value, than competing against github.
We only use GitHub for auth, we can add multiple options down the line.
We only want to use an old version for glibc which the centos:7 image takes care of. The old version of git used in debian:8 was causing problems with the uid/gid passthrough with no user in passwd.
No purpose when all the args are in the args parameter. We only need configArgs for bindAddrFromAllSources.
Made it clear --coder-bind is in beta and it's not shown by default in help output unless CS_BETA is non empty in the environment.
Will allow users the following flow:
code-server --expose my-name.https://<github-user>-<instance-name>.cdr.dev.Still a WIP and things above may change. We also need to open source the Go agent.
Sort of an alternative to Microsoft's Self Hosted Azure Codespaces. See #2077