Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add dagger 2 diagrams. #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nesquena merged 2 commits into codepath:master from ppiech:master
Dec 15, 2015
Merged

Add dagger 2 diagrams. #124

nesquena merged 2 commits into codepath:master from ppiech:master
Dec 15, 2015

Conversation

@ppiech
Copy link

@ppiech ppiech commented Dec 15, 2015

I'd like to add more content to the dagger 2 write up, including these diagrams for reference.

Copy link
Member

Copy link
Author

ppiech commented Dec 15, 2015

Not sure if i'm breaking any etiquette in this project, but I started updating the wiki doc for dagger as well.

Copy link
Member

No etiquette broken, please feel free to improve any of the guides as you see fit :)

nesquena added a commit that referenced this pull request Dec 15, 2015
@nesquena nesquena merged commit bc69267 into codepath:master Dec 15, 2015
Copy link
Member

I've merged your diagrams as well, feel free to include them in the guide to help illustrate how it works. We definitely need help reviewing our Dagger 2 guide.

Copy link
Member

rogerhu commented Dec 15, 2015

Feel free to review and edit...although do you think the diagrams actually
make things clearer? It seems at the very least they need explanation.
On Dec 15, 2015 12:02 PM, "Nathan Esquenazi" notifications@github.com
wrote:

I've merged your diagrams as well, feel free to include them in the guide
to help illustrate how it works. We definitely need help reviewing our
Dagger 2 guide.


Reply to this email directly or view it on GitHub
#124 (comment)
.

Copy link
Author

ppiech commented Dec 15, 2015

Many thanks for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /