Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Nov 5, 2022. It is now read-only.

Workaround for wrong indentation in array #44

Merged

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Mar 20, 2021

Workaround for #41

Copy link
Member

MGatner commented Mar 20, 2021

Please wildcard en as well since this will apply to all languages.

Copy link
Member Author

kenjis commented Mar 21, 2021

I've changed the exclude pattern.

Copy link
Member

MGatner commented Apr 11, 2021

I'm not sure who is in charge here. @louisl ? I can proceed with the merge but don't want to step on any toes. We would definitely like to have this.

Copy link
Collaborator

louisl commented Apr 12, 2021

Apologies, I've had a busy few weeks and haven't managed to get around to it, I'll get this done today

MGatner reacted with thumbs up emoji

Copy link
Member

MGatner commented Apr 27, 2021

@louisl Any update on this? I think this change is pretty non-intrusive so I'm inclined just to merge it but don't want to intrude on your territory.

@louisl louisl merged commit 3fd1571 into codeigniter4:develop Apr 27, 2021
Copy link
Collaborator

louisl commented Apr 28, 2021
edited
Loading

@MGatner Merged this and the other PR’s to develop downloaded it to prepare for a release and my computer died, spent all day trying to fix it but the HD is knackered. It’s getting on a bit and I was thinking about an upgrade. So I’ve ordered a new Mac coming tomorrow, will restore etc then I’ll do the release, so tomorrow night UK time (29th) realistically.

Copy link
Member

MGatner commented Apr 28, 2021

@louisl so sorry to hear about your compy! I hope you enjoy the new one. Let me know if you want any help in the meantime, I'm glad to do a release.

@kenjis kenjis deleted the workaround-for-indentation-tab-in-array branch June 11, 2021 01:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /