Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Replace use of 'join' function with 'implode' #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KimberleyCook merged 1 commit into codebar:gh-pages from bdsl:patch-1
May 6, 2022

Conversation

@bdsl
Copy link
Contributor

@bdsl bdsl commented May 6, 2022

If a student googles 'join' to learn more they'll just see that it's an alias of implode, and then have to read about implode.
https://www.php.net/manual/en/function.join.php

Better to just use implode so there's one less step.

If a student googles 'join' to learn more they'll just see that it's an alias of implode, and then have to read about implode. 
https://www.php.net/manual/en/function.join.php
Better to just use implode so there's one less step.
Copy link
Contributor Author

bdsl commented May 6, 2022

FYI I wrote my own PHP tutorial a couple of years ago. I don't know how much interest your students have in PHP though. https://a-moderately-short-php-tutorial.com/

I can also recommend Jon Duckett's book, which is came out recently and covers modern PHP.

Copy link
Contributor

@KimberleyCook KimberleyCook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@KimberleyCook KimberleyCook merged commit ad989ed into codebar:gh-pages May 6, 2022
Copy link
Contributor

Thanks @bdsl

Copy link
Contributor Author

bdsl commented May 6, 2022

That was quick! Thanks @KimberleyCook .

@bdsl bdsl deleted the patch-1 branch May 6, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KimberleyCook KimberleyCook KimberleyCook approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /