-
-
Notifications
You must be signed in to change notification settings - Fork 240
dropping support for ie8 #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dropping support for ie8 #339
Conversation
and so dropping support for ie8
Thanks Andy, this is great! 👌
Thoughts: On the one hand, this is the jQuery tutorial not the JS native Array method tutorial. On the other hand, you're 100% right, we should be teaching Array.prototype.forEach instead of $.each. While this section was probably originally intended to teach the jQuery method, I'm happy with this change.
I wonder whether we should include a section on advanced native Array/Object methods (e.g. map and reduce) at the end of tutorial 2, but that's a different topic.
js/lesson4/tutorial.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably clarify here that we mean the native method. How about we change the following
using the
forEach( )function
to something like
using the native Array
forEach( )method
I totally agree with splitting things out later on, especially for introducing terms like "method" rather than just "function". It was a bit tricky to talk about forEach without mentioning methods.
Like you said though, we can always introduce that later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 Thanks Andy!
ie8 is the last supported version of internet explorer for windows xp. It's usage is 1%-4% depending on which site you ask.
At the moment, we teach
$.eachas the way to iterate through an array, and I'd rather have students know the built-in array functions. Dropping ie8 means we can update our material, which is what this pull request does.Thoughts?