Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix cluster resizes #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hans-d merged 2 commits into cloudposse:main from clearbit:stroobl/cluster-resize
Mar 6, 2024
Merged

Conversation

@stroobl
Copy link
Contributor

@stroobl stroobl commented Feb 23, 2024 •
edited
Loading

what

Remove ignore changes for EBS volume size, it breaks resizes.

why

Impossible to (Terraform) resize a cluster with the current code and impossible to apply Terraform after a resize in the console, even after an import of the cluster.

I know there is ongoing work in #101 that might also include a fix for this, but it looks like it will take more time to get that done. This is a basic fix.

references

AWS provider issue: hashicorp/terraform-provider-aws#26031
Cloudposse module issue: #99

@stroobl stroobl requested review from a team as code owners February 23, 2024 10:59
Copy link

hans-d commented Feb 27, 2024

/terratest
cloudpossebot reacted with thumbs up emoji

Copy link

hans-d commented Mar 2, 2024

Copy link
Contributor Author

stroobl commented Mar 6, 2024

@stroobl can you do the action as mentioned in https://github.com/cloudposse/terraform-aws-msk-apache-kafka-cluster/actions/runs/8071242438/job/22050449751?pr=103 ?

@hans-d I don't see anything to commit after make init && make readme. Maybe because of the merge of the main branch now?

Copy link

hans-d commented Mar 6, 2024

/terratest
cloudpossebot reacted with thumbs up emoji

@hans-d hans-d added the minor New features that do not break anything label Mar 6, 2024
@hans-d hans-d enabled auto-merge (squash) March 6, 2024 23:39
@hans-d hans-d merged commit a885f49 into cloudposse:main Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hans-d hans-d hans-d approved these changes

@gberenice gberenice Awaiting requested review from gberenice gberenice is a code owner automatically assigned from cloudposse/contributors

Assignees

No one assigned

Labels

minor New features that do not break anything

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /