Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

style: make utility classes proper utilities #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adimiz1 merged 1 commit into cloudinary:master from vil02:340_hide_constructors_of_utils
Oct 20, 2024

Conversation

@vil02
Copy link
Contributor

@vil02 vil02 commented Oct 7, 2024

Brief Summary of Changes

All changed classes are now marked as final and their default constructor as private (i.e. it is hidden).

What does this PR address?

Are tests included?

  • Yes
  • No

Reviewer, please note:

Fixes #340.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I ran the full test suite before pushing the changes and all the tests pass.

@vil02 vil02 force-pushed the 340_hide_constructors_of_utils branch from 3c056ce to b51be82 Compare October 7, 2024 15:37
@vil02 vil02 force-pushed the 340_hide_constructors_of_utils branch from b51be82 to 19fc5a1 Compare October 7, 2024 15:42
@vil02 vil02 marked this pull request as ready for review October 7, 2024 16:11
Copy link
Contributor Author

vil02 commented Oct 15, 2024
edited
Loading

@adimiz1, @michal-sordyl-cloudinary, @colbyfayock: is there anything else what I should do regarding this pull request?

Copy link

thanks @vil02 for the PR. This will be reviewed by the relevant SDK team member.

While this will count towards hacktoberfest.com as the label is on the repository, just wanted to clarify that this will not count towards Cloudinary's Hacktoberfest swag based on the rules provided here: https://cld.media/hacktoberfest

we appreciate your contribution to improving the code health of the project!

Copy link
Contributor Author

vil02 commented Oct 16, 2024

just wanted to clarify that this will not count towards Cloudinary's Hacktoberfest swag based on the rules provided here: https://cld.media/hacktoberfest

@colbyfayock: could you please elaborate more on that? I thought that #340 (comment) counts as an approval.

Copy link

i think the confusion is that the person who was giving you the go ahead was just simply saying you could put together a PR when you asked:

So... could I create a pull request fixing this?

but because i could see how that could be confusing we'll just let it count towards the swag pack if it's approved and merged

vil02 reacted with thumbs up emoji

Copy link
Contributor Author

vil02 commented Oct 16, 2024

@colbyfayock: thanks! That is nice of you. Let's hope this will be merged in time.

@adimiz1 adimiz1 merged commit ab8f466 into cloudinary:master Oct 20, 2024
3 checks passed
@vil02 vil02 deleted the 340_hide_constructors_of_utils branch October 20, 2024 18:17
Copy link

@vil02 thanks for your contribution! this PR is eligible for free Cloudinary Hackatoberfest swag. Please send me an email at hacktoberfest@cloudinary.com with your name, GitHub username, and a link to the PR where I'll send further instructions.

Happy Hacktoberfest!

vil02 reacted with hooray emoji

Copy link
Contributor Author

vil02 commented Oct 21, 2024

@vil02 thanks for your contribution! this PR is eligible for free Cloudinary Hackatoberfest swag. Please send me an email at hacktoberfest@cloudinary.com with your name, GitHub username, and a link to the PR where I'll send further instructions.

Happy Hacktoberfest!

@colbyfayock: done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adimiz1 adimiz1 adimiz1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hide constructors of utility classes

AltStyle によって変換されたページ (->オリジナル) /