Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

style: remove unused imports #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adimiz1 merged 2 commits into cloudinary:master from vil02:remove_unused_imports
Oct 21, 2024
Merged

Conversation

@vil02
Copy link
Contributor

@vil02 vil02 commented Oct 2, 2024 •
edited
Loading

Brief Summary of Changes

I found some unused imports - this PR removes them.

What does this PR address?

Are tests included?

  • Yes
  • No

Reviewer, please note:

I did not create an issue for that, but clearly I can if really necessary.

This was created in a spirit of #337. Fixes #345.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I ran the full test suite before pushing the changes and all the tests pass.

@vil02 vil02 marked this pull request as ready for review October 2, 2024 18:23
@vil02 vil02 mentioned this pull request Oct 7, 2024
Copy link
Contributor Author

vil02 commented Oct 15, 2024 •
edited
Loading

@adimiz1, @michal-sordyl-cloudinary, @colbyfayock: is there anything else what I should do regarding this pull request?

Copy link

thanks @vil02 for the PR. This will be reviewed by the relevant SDK team member.

While this will count towards hacktoberfest.com as the label is on the repository, just wanted to clarify that this will not count towards Cloudinary's Hacktoberfest swag based on the rules provided here: https://cld.media/hacktoberfest

we appreciate your contribution to improving the code health of the project!

@adimiz1 adimiz1 self-requested a review October 21, 2024 20:32
@adimiz1 adimiz1 merged commit c4d7b29 into cloudinary:master Oct 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adimiz1 adimiz1 adimiz1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unused imports

AltStyle によって変換されたページ (->オリジナル) /