Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fixes uncaught errors in concurrency loop #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colbyfayock merged 1 commit into main from bug/94-uncaught-errors
Nov 10, 2023

Conversation

@colbyfayock
Copy link
Collaborator

@colbyfayock colbyfayock commented Nov 10, 2023

Description

Concurrency was added for parallel uploads which introduced a bug where the try/catch wrapping this didn't properly catch the errors being thrown from within the async functions.

This moves the try/catch inside of each upload process

Issue Ticket Number

Fixes #94

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

Copy link

netlify bot commented Nov 10, 2023 •
edited
Loading

✅ Deploy Preview for netlify-plugin-cloudinary ready!

Name Link
🔨 Latest commit 69cfedd
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-cloudinary/deploys/654e86b6203e6f00085ecec2
😎 Deploy Preview https://deploy-preview-95--netlify-plugin-cloudinary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colbyfayock colbyfayock merged commit 2c6a33b into main Nov 10, 2023
@colbyfayock colbyfayock deleted the bug/94-uncaught-errors branch November 10, 2023 19:47
github-actions bot pushed a commit that referenced this pull request Nov 10, 2023 
## [1.13.1](v1.13.0...v1.13.1) (2023年11月10日)
### Bug Fixes
* Fixes uncaught errors in concurrency loop ([#95](#95)) ([2c6a33b](2c6a33b)), closes [#11](#11) [#94](#94)
Copy link

🎉 This PR is included in version 1.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Failed upload errors don't get caught, leaking out of build process

2 participants

AltStyle によって変換されたページ (->オリジナル) /