Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixes Netlify URL #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colbyfayock merged 3 commits into main from bug/83-deploy-url
Sep 19, 2023
Merged

Fixes Netlify URL #84

colbyfayock merged 3 commits into main from bug/83-deploy-url
Sep 19, 2023

Conversation

@colbyfayock
Copy link
Collaborator

@colbyfayock colbyfayock commented Sep 19, 2023

Description

Issue Ticket Number

Fixes #83

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

Copy link

netlify bot commented Sep 19, 2023
edited
Loading

Deploy Preview for netlify-plugin-cloudinary ready!

Name Link
🔨 Latest commit 7cbefe4
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-cloudinary/deploys/6509e9d4e09b580008deb929
😎 Deploy Preview https://deploy-preview-84--netlify-plugin-cloudinary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colbyfayock colbyfayock merged commit 3a83908 into main Sep 19, 2023
@colbyfayock colbyfayock deleted the bug/83-deploy-url branch September 19, 2023 18:43
github-actions bot pushed a commit that referenced this pull request Sep 19, 2023
## [1.10.2](v1.10.1...v1.10.2) (2023年09月19日)
### Bug Fixes
* Fixes Netlify URL ([#84](#84)) ([3a83908](3a83908)), closes [#11](#11) [#83](#83)
Copy link

🎉 This PR is included in version 1.10.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

When will this fix be live on Netlify? I don't see a Change Version option for the Cloudinary plugin like some others. I am unable to build my site today due to this URL issue and had to revert it to a previous deployment.

Copy link
Collaborator Author

hey @JingshanDu i'm hoping by tomorrow this will go out. it's already been reviewed by the Netlify team, just waiting for the actual deployment

netlify/plugins#1257

i plan on following up with them tomorrow

JingshanDu reacted with thumbs up emoji

Copy link
Collaborator Author

@JingshanDu good news, this is now deployed on netlify, so everything should be good to go, but please report an Issue if you run into anything

JingshanDu reacted with thumbs up emoji

Copy link

@colbyfayock Thanks for the update! This version is working well and has resolved the issue.

matiasfha pushed a commit to matiasfha/netlify-plugin-cloudinary that referenced this pull request Sep 23, 2023
# Description
<!-- Include a summary of the change made and also list the dependencies
that are required if any -->
## Issue Ticket Number
<!-- Specifiy which issue this fixes by referencing the issue number
(`cloudinary-community#11`) or issue URL. -->
<!-- Example: Fixes
cloudinary-community#1 -->
Fixes cloudinary-community#83 
## Type of change
<!-- Please select all options that are applicable. -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
# Checklist
<!-- These must all be followed and checked. -->
- [ ] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [ ] I have created an
[issue](https://github.com/colbyfayock/netlify-plugin-cloudinary/issues)
ticket for this PR
- [ ] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/colbyfayock/netlify-plugin-cloudinary/pulls)
for the same update/change?
- [ ] I have performed a self-review of my own code
- [ ] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Host of deployed images is undefined when using fetch

AltStyle によって変換されたページ (->オリジナル) /