-
Notifications
You must be signed in to change notification settings - Fork 19
migrate to typescript #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to typescript #63
Conversation
✅ Deploy Preview for netlify-plugin-cloudinary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# [1.7.0](v1.6.0...v1.7.0) (2023年09月06日) ### Features * migrate to typescript ([#63](#63)) ([f9b960f](f9b960f))
@allcontributors please add @matiasfha for code
1 similar comment
@allcontributors please add @matiasfha for code
I've put up a pull request to add @matiasfha! 🎉
Adds @matiasfha as a contributor for code. This was requested by colbyfayock [in this comment](#63 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasfha was there a context to the addition of !apiKey and !apiSecret here? this now breaks builds that are only using the fetch API, which only requires cloud name
the plkugin hasn't been updated on netlify so its not impacting anyone at the moment but will once updated
before fixing this curious why this was added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC this was added to satisfy TS
Let me create another PR to remove that restriction and also add a test for that build case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the TS error
CleanShot 2023年09月19日 at 10 49 35@2x
I'm working on a change
# Description This pr migrates the project to Typescript with correct typings, build process and keeping the tests running ## Issue Ticket Number Fixes ## Type of change <!-- Please select all options that are applicable. --> - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [X] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [X] I have created an [issue](https://github.com/colbyfayock/netlify-plugin-cloudinary/issues) ticket for this PR - [X] I have checked to ensure there aren't other open [Pull Requests](https://github.com/colbyfayock/netlify-plugin-cloudinary/pulls) for the same update/change? - [X] I have performed a self-review of my own code - [X] I have run tests locally to ensure they all pass - [X] I have commented my code, particularly in hard-to-understand areas - [X] I have made corresponding changes needed to the documentation --------- Co-authored-by: Colby Fayock <fayock@gmail.com>
# [1.7.0](cloudinary-community/netlify-plugin-cloudinary@v1.6.0...v1.7.0) (2023年09月06日) ### Features * migrate to typescript ([cloudinary-community#63](cloudinary-community#63)) ([f9b960f](cloudinary-community@f9b960f))
Adds @matiasfha as a contributor for code. This was requested by colbyfayock [in this comment](cloudinary-community#63 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Description
This pr migrates the project to Typescript with correct typings, build process and keeping the tests running
Issue Ticket Number
Fixes
Type of change
Checklist