-
Couldn't load subscription status.
- Fork 19
Support Automated Image Scaling with Client Hints #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Automated Image Scaling with Client Hints #105
Conversation
...ize.width so users can follow the instructions in https://cloudinary.com/blog/automatic_responsive_images_with_client_hints * Add Inputs maxSize.crop so users can specify a cloudinary crop mode for their images
✅ Deploy Preview for netlify-plugin-cloudinary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* Include hyperlinks for new people
Happy to split the unrelated documentation updates into a separate PR if it would make things easier 🎉
thanks @gshel changes look good
im curious to hear about your use case with the crop mode. the reason i hadnt originally allowed that to be configurable was the thought that blanket cropping images across the site would present a challenge for the variety ways an image could be presented, where i was going to eventually allow someone to pass in parameters, such as a URL query params perhaps, to do that programmatically
as far as client hints - what do you think about added the option to allow people to inject the Client Hints meta tag to their site?
perhaps if they pass in an option such as:
clientHints: ["Dpr", "Viewport-Width", "Width"]
we would add the tags:
<meta http-equiv="accept-ch" content="Dpr, Viewport-Width, Width">
<meta http-equiv="delegate-ch" content="sec-ch-width https://res.cloudinary.com; sec-ch-dpr https://res.cloudinary.com; sec-ch-viewport-width https://res.cloudinary.com;">
based on those values
thoughts?
oh, can you also update the documentation website table of configuration options? my intent is to eventually remove them from the README and instead only have them on the documentation site to avoid separate maintenance
it should more or less be the same code that you have already updated, just need to copy and paste i believe
Uh oh!
There was an error while loading. Please reload this page.
Description
The following changes allow users to follow the suggestions outlined in How to Scale an Image Automatically using Client Hints, specifically:
Changes made:
Issue Ticket Number
Fixes #104
Type of change
Checklist