Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Create tests #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

@nstapelbroek
Copy link
Contributor

@nstapelbroek nstapelbroek commented Oct 19, 2018

Hi there 👋

This is an start for #10 allowing you to run test in a CI environment like Travis. There is a successful build of this branch right here.

I had to change a couple of things to get this done. Details below.

What has been done

  • Dropped support for PHP 5.6 since you were already using the return types
  • Listed the Zend Framework dependencies used in composer.json so you can develop and test this module without integrating it in a complete ZF application.
  • Created a Travis build matrix/pipeline that will test the module across all PHP 7 versions
  • Created two tests who assert the default config, so no actual behavioral tests

How to test

  • Checkout PR
  • Run composer update
  • Acknowledge that PHPunit is installed
  • Run ./vendor/bin/phpunit and acknowledge that the tests run

Copy link
Member

Looks great, Nico, I'll review and merge it over the weekend if possible.

nstapelbroek reacted with thumbs up emoji

@markushausammann markushausammann merged commit 31e44f9 into cloud-solutions:master Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markushausammann markushausammann Awaiting requested review from markushausammann

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /