-
Couldn't load subscription status.
- Fork 19
Create tests #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
markushausammann
merged 6 commits into
cloud-solutions:master
from
nstapelbroek:feature/initial-test-setup
Oct 20, 2018
Merged
Create tests #57
markushausammann
merged 6 commits into
cloud-solutions:master
from
nstapelbroek:feature/initial-test-setup
Oct 20, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the code already uses the return types there is no way of running this in PHP 5.6
Looks great, Nico, I'll review and merge it over the weekend if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
This is an start for #10 allowing you to run test in a CI environment like Travis. There is a successful build of this branch right here.
I had to change a couple of things to get this done. Details below.
What has been done
How to test
./vendor/bin/phpunitand acknowledge that the tests run