-
Couldn't load subscription status.
- Fork 5
v1.1rc #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
they are basically just duplicate info anyways
to compare adoption between schools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good! There are a few things that I'd recommend for readability going forward, but overall I like where it's going.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include a link, in case people don't know the URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its in the github description thingy. im thinking this part of the README will eventually be moved to like a support page or guides page or something on the classclock website
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend putting the flags into an object/enum to really drive home the fact that they're flags (vs. constant variables/strings). This way, anytime you reference a flag it would show as ScheduleFlags.DAY_OFF_FLAG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that sounds good. one of us can add it when we have time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been done (i think) in the react version
Oh, and one more thing. Since this project is starting to get pretty big, do you want to start moving over to TypeScript? From personal experience - it helps in larger projects.
would Typescript break compatibility with any browsers or introduce bulky dependencies?
because i messed up and prematurely tagged c178194 as v1.0 (has been fixed now), I am closing this and am going to resubmit this PR on a v0.2rc branch
No description provided.