-
Notifications
You must be signed in to change notification settings - Fork 38
feat(crafting-schema): add organization resolver #2465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crafting-schema): add organization resolver #2465
Conversation
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if it doesn't have metadata as is an old format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated unmarshalling to not return an error when old schema is used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why return strings and not bytes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, it was there to make it consistent with platform
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is superspecific to contracts. I think we can deprecate the field raw_contract in the proto definition and call it raw_resource, for example, just to make it generic enough so that we can reuse this interface for other resources (policies, etc). Would it be possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are using raw_schema in other places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming is all over the place, policies use raw_schema, policy groups raw_group, contracts raw_contract. Chainloop OSS will be only responsible for contracts so I think there's no need to add another field to proto def
This PR updates current organization middleware with handler for in schema defined organization.