-
Notifications
You must be signed in to change notification settings - Fork 56
refactor(dockerfile): builder multistage pattern & random uid user support #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please note: this build depends on the work being done in verdaccio under verdaccio/verdaccio#864, in order to build this, it's needed to create a manual build of that verdaccio's PR and manually tag it:
# In verdaccio PR #864 cd .. yarn build:docker docker tag verdaccio:latest verdaccio/verdaccio:3.3 # Now build this image cd ... yarn build:docker # available as verdaccio-gitlab:latest
19a02fc to
efea6da
Compare
I'm changing this to make it depend on verdaccio/verdaccio:4.x-next. But until the changes in the pending PR in verdaccio for refactored dockerfile are applied, this won't work unless we build manually locally (see comment above)
It's out
docker pull verdaccio/verdaccio:4.x-next
This is great!
Please seperate the fixes for gitlab.js and package.json into a dedicated PR as they are not related to the docker build.
- build image based on current upstream verdaccio refactor, only building the plugin code and then symlinking the plugin code - randomized uid support (e.g. openshift) - plugin install directory is read-only
efea6da to
6edd701
Compare
building the plugin code and then symlinking the plugin code