-
Notifications
You must be signed in to change notification settings - Fork 56
Feat/transpile #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/transpile #18
Conversation
@juanpicado what do you think about that?
package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, I do not use caret, just matter of taste. I think is much better have the full control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, I fix the versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verdaccio v3 already support ES6 classes. It's your decision do Object.create(Auth.prototype); or just do eg: https://github.com/verdaccio/verdaccio-htpasswd/blob/master/src/index.js#L9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do that at a later step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be careful here, people still use Node4, verdaccio v2.x still support Node 4. If you switch to Node6 (which is the minimum since last month. You need to warn users (README or something), otherwise, they will get compiler errors on runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 4.x release line is going end of life April 30th, I add engines to package.json and a hint to the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--source-maps I'd remove that, otherwise, you will inflate your package. You always can do npm run build -- --source-maps which is not handy, but still, save.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the map files are not packaged with the npm, but they are very useful to debug, I keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this https://www.verdaccio.org/docs/en/node-api.html handy for you instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just starting verdaccio with the cli is sufficient for the moment, maybe at a later step.
@juanpicado thanks for all the review comments, I look at it.
No description provided.