Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

extracted timezone env from composers into .env file #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bscheshirwork merged 3 commits into bscheshirwork:master from atipezda:fix_timezone
Sep 21, 2020

Conversation

@atipezda
Copy link
Contributor

@atipezda atipezda commented Sep 8, 2020

That changes allows user to change timezone quickly in .env file and also it standardize same timezone across all containers

Copy link
Owner

Thank you for contribution. Add default value of TZ for back compatibility please.

Copy link
Contributor Author

Hi, what do You mean by default value of TZ. I thought that TZ=Europe/Moscow in .env_example file is enough. I must point out that I'm new into open-source contributing so I'm still learning 😄

Copy link
Owner

I tell about this case:

  • I already have composition
  • I already have copy of .env_example
  • I pull new changes
  • I have empty TZ instead of old value 'Europe/Moscow'

I think we need this

 environment:
 TZ: "${TZ:-Europe/Moscow}"

Can you check how to work it please?

see docker/docs#6914 (comment)

Copy link
Contributor Author

Oh okay i didn't know about default variables in docker envs. I will edit the pr tommorow

Copy link
Contributor Author

Thank you for contribution. Add default value of TZ for back compatibility please.

Done.

@bscheshirwork bscheshirwork merged commit 429c4ae into bscheshirwork:master Sep 21, 2020
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /