-
-
Couldn't load subscription status.
- Fork 1.1k
Add actor specific class name #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Very nice idea. Should we use "actorVistor" instead of "actor0"? I guess number based has fewer pitfalls.
I wonder if the CSS nth select would have worked without your change, for example:
.actor rect:nth-child(1), .actor path:nth-child(1) {
fill: #f9f;
}
Well either way I'll review your changes shortly.
dist/sequence-diagram.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should make this change in src/theme-snap.js#L231 not in dist/. dist/ is generated from the files in src/, and can be regenerated by running make.
Otherwise LGTM.
I couldn't get .actor:nth-child() or .actor:nth-of-type() to work but I did get it to work with group. One nice side-effect is it's possible to address each box seperately (e.g. top and bottom of the same actor). The downside is having to set both boxes.
Uses group
g:nth-of-type(2) rect
Or a more specific call to group.class
g.actor:nth-of-type(2) rect
Allows CSS attributes to override individual actors.
Example to be used in
sequence-diagram.css:screen shot 2017年06月04日 at 2 48 33 pm
screen shot 2017年06月04日 at 2 50 23 pm