Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Small fixes to bash loops chapter #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobbyiliev merged 1 commit into bobbyiliev:main from marcelozarate:bash-loops-fixes
Oct 13, 2022

Conversation

@marcelozarate
Copy link
Contributor

@marcelozarate marcelozarate commented Oct 13, 2022

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🚩 Other

Description

Some changes to "bash loops" chapter:

  • Added period after list items, as it is used in the first one.
  • Changed your_conditions to your_commands in example (correct me if I misinterpret it).
  • Print i variable name to lowercase.
  • Replaced " and " for standard quotarion marks "

Related Tickets & Documents

Added to documentation?

  • 📜 readme
  • 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

Copy link
Owner

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for those improvements!

@bobbyiliev bobbyiliev merged commit 39916ef into bobbyiliev:main Oct 13, 2022
@marcelozarate marcelozarate deleted the bash-loops-fixes branch October 17, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobbyiliev bobbyiliev bobbyiliev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /