This repository was archived by the owner on Feb 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 662
PHP 8.2 Build and Fix Tests #1047
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@internal This property is not meant to be used or overwritten outside the framework.
Codecov Report
@@ Coverage Diff @@ ## master #1047 +/- ## ============================================ + Coverage 90.94% 91.34% +0.39% - Complexity 0 2 +2 ============================================ Files 68 68 Lines 1866 2056 +190 ============================================ + Hits 1697 1878 +181 - Misses 169 178 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closed
- Added PHP 8.2 to the matrix
- Updated composer dependencies for Laravel 9 support
- Fixed a bug where
$this->componentswas used instead of$this->info()in StartServer command
Wernke96
commented
Oct 27, 2022
@mpociot could you take a look at this pr.
parallels999
commented
Jan 6, 2023
@mpociot ping :/
angeljqv
commented
Aug 24, 2023
@mpociot hi, still there?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't use
$this->componentsbecause it is@internallaravel-websockets/src/Console/Commands/StartServer.php
Lines 262 to 265 in 1f25913
https://github.com/laravel/framework/blob/a8a529d371faaa38bde087aa6171a5b53a6a8760/src/Illuminate/Console/Concerns/InteractsWithIO.php#L18-L25