-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: Improve UDP port list handling, unnecessary .clone()
#751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR changes the generator and the generated output has changed. I would image it should stay the same. Give me some time to look at it :)
I assume the loop logic should stay the same though,
Just to confirm, the generator is automatically generated right?
Cheers ;)
#750 went in last week which should add generated.rs to the .gitignore file.
Worth rebasing off master and seeing if that ignores those changes...?
#750 went in last week which should add
generated.rsto the.gitignorefile.Worth rebasing off
masterand seeing if that ignores those changes...?
There are also merge conflicts with the generated.rs
Removed a few unnecessary
.clone()s.The
.clean()is also avoided by creating a local variable.