-
Couldn't load subscription status.
- Fork 96
new method to construct an SO3 object #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
myeatman-bdai
merged 3 commits into
bdaiinstitute:master
from
petercorke:new-so3-rotatedvector
Jan 30, 2025
Merged
new method to construct an SO3 object #159
myeatman-bdai
merged 3 commits into
bdaiinstitute:master
from
petercorke:new-so3-rotatedvector
Jan 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@petercorke
petercorke
requested review from
jhavl and
myeatman-bdai
as code owners
January 20, 2025 21:12
myeatman-bdai
myeatman-bdai
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
return cls(np.c_[x, y, z], check=True)
@classmethod
def RotatedVector(cls, v1: ArrayLike3, v2: ArrayLike3, tol=20) -> Self:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This basically accomplishes the feature requested here #37! Nice.
@myeatman-bdai
myeatman-bdai
merged commit Jan 30, 2025
659ba24
into
bdaiinstitute:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construct an SO3 object from a vector and its rotated image. ie. given$v$ and ${\bf R} v$ compute $\bf R$ . Includes tests and doco.