-
Couldn't load subscription status.
- Fork 96
Add q2str to convert quaternion to string
#158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ity of `qprint(..., file=None)` which is unintuitive. Added deprecation notice to `qprint`, tests and doco.
@petercorke
petercorke
requested review from
jhavl and
myeatman-bdai
as code owners
January 19, 2025 12:41
myeatman-bdai
myeatman-bdai
requested changes
Jan 22, 2025
spatialmath/base/quaternions.py
Outdated
By default the string is written to `sys.stdout`.
If `file=None` then a string is returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line in the doc-string is from a previous version of your code; I don't see a file argument.
myeatman-bdai
myeatman-bdai
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@myeatman-bdai
myeatman-bdai
merged commit Jan 26, 2025
a08f25e
into
bdaiinstitute:master
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
q2str()to convert a quaternion to a string, replacing old functionality ofqprint(..., file=None)which is unintuitive. Added deprecation notice toqprintif this type of call is invoked, butfilecan be set to any valid file-like object reference.Tests and doco provided.