Fix for issue #144. #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

myeatman-bdai merged 1 commit into bdaiinstitute:master from petercorke:issue-144

Jan 30, 2025

Merged

Fix for issue #144. #155

myeatman-bdai merged 1 commit into bdaiinstitute:master from petercorke:issue-144

Jan 30, 2025

Conversation

@petercorke

Copy link

Collaborator

@petercorke petercorke commented Jan 19, 2025

The dim option of getunit() was poorly defined and inconsistently used. Added a vector option to enforce a vector/scalar return, and dim is only used for checking. Fixed/extended unit tests and all calls to getunit() where this confusion occurred. Also fixed some minor sphinx doco formatting problems.

This version of the PR excludes the commit noise from the ongoing black formatting issue.

@petercorke


 Fix for issue bdaiinstitute#144 . The dim  option of getunit()  was ...

338ba20

...poorly defined and inconsistently used. Added a `vector` option to enforce a vector/scalar return, and `dim` is only used for checking. Fixed tests and all calls to `getunit()` where this case occurred. Also fixed some minor sphinx doco formatting problems.