-
Couldn't load subscription status.
- Fork 27
Signing with InvariantCulture, so different calendars produce good ou... #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcuff
bcuff
approved these changes
Jan 29, 2021
Ahh thank you for the fix! I'll test things out on my end and publish a new package if it all checks out.
@janireu published here - https://www.nuget.org/packages/Elasticsearch.Net.Aws/7.0.6
Thanks a lot for the speedy review and publishing 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...tput.
For example, in Thailand they are 543 years ahead, when formatting a date using
date.ToString("yyyyMMdd"), it will produce25640129. The library needs to format using the invariant culture to avoid issues with different calendars falling out of sync with AWS.The test is not great but I've included it so the issue is easy to reproduce. To make it more elegant I would need to extract
DateTime.UtcNowfromSignV4Util.cswhich it's quite a bigger change.