-
Notifications
You must be signed in to change notification settings - Fork 27
Upgrade to ElasticSearch.Net 7.0 (Alpha release) #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Elasticsearch.Net were previously hedging their bets on using HttpClient in Fullframework. They were was using HttpWebRequest and httpclient in net standard, there is no longer this compile split, so we can remove it from here too.
Removed unreferenced dependencies * Newtonsoft.Json * Nest Remove transitive dependencies * Elasticsearch.Net
Type parameter seems to have disappeared from the Get and Create Api
was previously pulling netstandard1.3 / full framework 4.5.1, now only depends on netstandard2.0
My desire is to add Aws XRay support to AwsHttpConnection. It may be better implemented as a subclass like AwsHttpConnectionWithXRay as XRay will thrown runtime exceptions if not configured correctly.
This isn't a huge value-add so this could just as easily be something people add in their own code base if you don't want to add it to this library.
using Amazon.XRay.Recorder.Handlers.System.Net; ... protected override HttpMessageHandler CreateHttpClientHandler(RequestData requestData) { var innerHandler = base.CreateHttpClientHandler(requestData); return new HttpClientXRayTracingHandler(innerHandler); }
required csproj reference:
<PackageReference Include="AWSXRayRecorder.Handlers.System.Net" Version="2.5.*" />
Also noticed on old nuspec file in there that probably needs deleting?
Elasticsearch.Net.Aws.nuspec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elasticsearch.Net is up to beta1 now, this PR will need updating
https://www.nuget.org/packages/Elasticsearch.Net/7.0.0-beta1
Hey thanks for the PR. this looks good for the most part. I'll likely merge and make some package related tweaks before publishing. Since NEST is still a pre-release I'll also publish this as a pre-release.
@williamdenton https://www.nuget.org/packages/Elasticsearch.Net.Aws/7.0.0-beta1 Let me know if there are any issues. Thanks!
Apologies if I've jumped the gun a bit here, I had some free time this weekend and decided to have a crack at this on my own. #45
Happy to discuss my approach, also fine if you would rather do this bit of fairly critical work yourself.
I'm not 100% sure how to indicate that this 7.0 build is alpha in the CI for this repo, so this shouldn't be merged if there is an automated process that will deploy this to nuget as v7.0.0 without a pre release tag.