Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Symfony 4.4/5.0 compatibility #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rquadling merged 1 commit into bamarni:master from brainexe:master
Mar 4, 2020
Merged

Conversation

@brainexe
Copy link
Contributor

@brainexe brainexe commented Jan 27, 2020

With Symfony 4.4 2 methods changed which is throwing a deprecation warning and with Symfony 5.0 the support dropped:

  • changed Process constructor (only possible to pass a string array instead of a plain string)
  • Command::execute() must return int now

e.g.

PHP Fatal error: Uncaught TypeError: Return value of "Bamarni\Symfony\Console\Autocomplete\DumpCommand::execute()" must be of the type int, NULL returned. in /www/foe/libs/external/symfony/console/Command/Command.php:258
Stack trace:
#0 /www/foe/libs/external/symfony/console/Application.php(925): Symfony\Component\Console\Command\Command->run()
#1 /www/foe/libs/external/symfony/console/Application.php(265): Symfony\Component\Console\Application->doRunCommand()
#2 /www/foe/libs/external/symfony/console/Application.php(141): Symfony\Component\Console\Application->doRun()
#3 /www/foe/libs/external/bamarni/symfony-console-autocomplete/bin/symfony-autocomplete(49): Symfony\Component\Console\Application->run()
#4 {main}

Chi-teck reacted with thumbs up emoji
@brainexe brainexe force-pushed the master branch 3 times, most recently from edd7315 to 17cb112 Compare January 28, 2020 10:28 
 - changed Process constructor
 - Command::execute() must return int
Copy link
Collaborator

Thank you for this. I'll try to get it merged and released this week.
brainexe reacted with hooray emoji

Copy link
Contributor Author

brainexe commented Mar 3, 2020

ping, any update here?

Copy link
Collaborator

I have IRL interference this last few months. Will try and get to it this week.

@rquadling rquadling merged commit a121f79 into bamarni:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /