-
Couldn't load subscription status.
- Fork 33
Optimize by run single list --format=xml #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize by run single list --format=xml #34
Conversation
The existing code is very slow with more than a couple of commands (especially so on a Docker for Mac osxfs host volume mount). The symfony/console library supports fetching a single combined xml of all commands, so using this reduces the number of console command runs to one, massively speeding it up.
Previously this was the case for list --raw strip_tags is used there too https://github.com/symfony/console/blob/master/Descriptor/TextDescriptor.php#L248
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simplexml MAY be disabled (http://www.php.net/manual/en/simplexml.installation.php using the --disable-simplexml option). Adding this extension as a requirement in composer.json would be the easiest way to deal with that. Considering this extension is enabled by default, I'd say that this is a safe solution. (http://www.php.net/manual/en/simplexml.installation.php#121170)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, would be good to add that to the composer.json. Just a note though that this extension was already being used in the deleted code below, but I'm happy to add it anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha! So it was already missing. Hopefully this will be accepted and merged soon. Nice work and thank you for the PR.
Thanks, really nice one
Any chance of a release please?
@bamarni Please can you make a release?
@bamarni Does anyone else have release capabilities? It would be really nice for this to be released.
The existing code is very slow with more than a couple of commands (especially so on a Docker for Mac osxfs host volume mount).
The symfony/console library supports fetching a single combined xml of all commands, so using this reduces the number of console command runs to one, massively speeding it up.