This repository was archived by the owner on Jul 27, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 76
Check defaultValue - use measure for less undefined height or widths - remove default fontSize #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks
I have adopted the first and third questions.
But I didn't use the second question for the following reasons:
- The measurement method is asynchronous and increases the computational overhead.
- The measurement method calculated width and height seem to contain padding, but I need width and height does not include padding.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check defaultValue
If the multiline input text box has a default value, it is not recognized by the plugin as text as the plugin only checks the text property. Added proposal to also check the defaultValue.
Use measure for less undefined height or widths
When calculating the height/ width, the plugin uses the property value of height and width, it would be better to calculate it with the measure function.
Remove default fontSize
Why do you put a default fontSize of 17 in de styles? If the user does not provide a style, it will use font size 17 for calculating cursor height, resulting in a bad calculation. Put it in comment line to show the user he could add specific styling used for the calculation.