Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Workshop content update: AgentCore Memory integration - Session based #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giryoong-kim wants to merge 17 commits into awslabs:main
base: main
Choose a base branch
Loading
from giryoong-kim:main

Conversation

@giryoong-kim
Copy link

@giryoong-kim giryoong-kim commented Oct 17, 2025
edited
Loading

Amazon Bedrock AgentCore Samples Pull Request

Important

  1. We strictly follow a issue-first approach, please first open an issue relating to this Pull Request.
  2. Once this Pull Request is ready for review please attach review ready label to it. Only PRs with review ready will be reviewed.

Issue number:

Concise description of the PR

Changes to ..., because ...

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • Add your name to CONTRIBUTORS.md
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you uploading a dataset?
  • Have you documented Introduction, Architecture Diagram, Prerequisites, Usage, Sample Prompts, and Clean Up steps in your example README?
  • I agree to resolve any issues created for this example in the future.
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Copy link

Check out this pull request on ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added 01-tutorials 01-tutorials 07-AgentCore-E2E 01-tutorials/07-AgentCore-E2E labels Oct 17, 2025
"\n",
"memory_config = AgentCoreMemoryConfig(\n",
" memory_id=memory_id,\n",
" session_id=session_id,\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

str(session_id)

Copy link
Author

@giryoong-kim giryoong-kim Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link

Latest scan for commit: 10b3541 | Updated: 2025年10月20日 19:53:33 UTC

Security Scan Results

Scan Metadata

  • Project: ASH
  • Scan executed: 2025年10月20日T19:53:14+00:00
  • ASH version: 3.0.0

Summary

Scanner Results

The table below shows findings by scanner, with status based on severity thresholds and dependencies:

Column Explanations:

Severity Levels (S/C/H/M/L/I):

  • Suppressed (S): Security findings that have been explicitly suppressed/ignored and don't affect the scanner's pass/fail status
  • Critical (C): The most severe security vulnerabilities requiring immediate remediation (e.g., SQL injection, remote code execution)
  • High (H): Serious security vulnerabilities that should be addressed promptly (e.g., authentication bypasses, privilege escalation)
  • Medium (M): Moderate security risks that should be addressed in normal development cycles (e.g., weak encryption, input validation issues)
  • Low (L): Minor security concerns with limited impact (e.g., information disclosure, weak recommendations)
  • Info (I): Informational findings for awareness with minimal security risk (e.g., code quality suggestions, best practice recommendations)

Other Columns:

  • Time: Duration taken by each scanner to complete its analysis
  • Action: Total number of actionable findings at or above the configured severity threshold that require attention

Scanner Results:

  • PASSED: Scanner found no security issues at or above the configured severity threshold - code is clean for this scanner
  • FAILED: Scanner found security vulnerabilities at or above the threshold that require attention and remediation
  • MISSING: Scanner could not run because required dependencies/tools are not installed or available
  • SKIPPED: Scanner was intentionally disabled or excluded from this scan
  • ERROR: Scanner encountered an execution error and could not complete successfully

Severity Thresholds (Thresh Column):

  • CRITICAL: Only Critical severity findings cause scanner to fail
  • HIGH: High and Critical severity findings cause scanner to fail
  • MEDIUM (MED): Medium, High, and Critical severity findings cause scanner to fail
  • LOW: Low, Medium, High, and Critical severity findings cause scanner to fail
  • ALL: Any finding of any severity level causes scanner to fail

Threshold Source: Values in parentheses indicate where the threshold is configured:

  • (g) = global: Set in the global_settings section of ASH configuration
  • (c) = config: Set in the individual scanner configuration section
  • (s) = scanner: Default threshold built into the scanner itself

Statistics calculation:

  • All statistics are calculated from the final aggregated SARIF report
  • Suppressed findings are counted separately and do not contribute to actionable findings
  • Scanner status is determined by comparing actionable findings to the threshold
Scanner S C H M L I Time Action Result Thresh
bandit 0 0 0 0 5 0 858ms 0 PASSED MED (g)
cdk-nag 0 0 0 0 0 0 29.8s 0 PASSED MED (g)
cfn-nag 0 0 0 0 0 0 6ms 0 PASSED MED (g)
checkov 0 0 0 0 0 0 4.9s 0 PASSED MED (g)
detect-secrets 0 3 0 0 0 0 824ms 3 FAILED MED (g)
grype 0 0 0 0 0 0 32.0s 0 PASSED MED (g)
npm-audit 0 0 0 0 0 0 165ms 0 PASSED MED (g)
opengrep 0 0 0 0 0 0 <1ms 0 SKIPPED MED (g)
semgrep 0 0 0 0 0 0 16.2s 0 PASSED MED (g)
syft 0 0 0 0 0 0 2.6s 0 PASSED MED (g)

Detailed Findings

Show 3 actionable findings

Finding 1: SECRET-SECRET-KEYWORD

  • Severity: HIGH
  • Scanner: detect-secrets
  • Rule ID: SECRET-SECRET-KEYWORD
  • Location: 01-tutorials/07-AgentCore-E2E/lab_helpers/utils.py:240

Description:
Secret of type 'Secret Keyword' detected in file '01-tutorials/07-AgentCore-E2E/lab_helpers/utils.py' at line 240

Code Snippet:

Secret of type Secret Keyword detected

Finding 2: SECRET-SECRET-KEYWORD

  • Severity: HIGH
  • Scanner: detect-secrets
  • Rule ID: SECRET-SECRET-KEYWORD
  • Location: 01-tutorials/07-AgentCore-E2E/lab_helpers/utils.py:232

Description:
Secret of type 'Secret Keyword' detected in file '01-tutorials/07-AgentCore-E2E/lab_helpers/utils.py' at line 232

Code Snippet:

Secret of type Secret Keyword detected

Finding 3: SECRET-SECRET-KEYWORD

  • Severity: HIGH
  • Scanner: detect-secrets
  • Rule ID: SECRET-SECRET-KEYWORD
  • Location: 01-tutorials/07-AgentCore-E2E/lab_helpers/utils.py:18

Description:
Secret of type 'Secret Keyword' detected in file '01-tutorials/07-AgentCore-E2E/lab_helpers/utils.py' at line 18

Code Snippet:

Secret of type Secret Keyword detected

Report generated by Automated Security Helper (ASH) at 2025年10月20日T19:53:09+00:00

"\n",
"\n",
"# Import AgentCore Memory client and Hook events from strands\n",
"from bedrock_agentcore.memory import MemoryClient\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update this part please ? instead use

from bedrock_agentcore_starter_toolkit.operations.memory.manager import MemoryManager


memory_manager = MemoryManager(region_name=region)
memory = memory_manager.get_or_create_memory(name="memoryName")
memory_id = memory["id"]

Copy link
Author

@giryoong-kim giryoong-kim Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied the suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akshseh akshseh akshseh requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

01-tutorials 01-tutorials 07-AgentCore-E2E 01-tutorials/07-AgentCore-E2E

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /