-
Notifications
You must be signed in to change notification settings - Fork 467
Workshop content update: AgentCore Memory integration - Session based #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: giryoong-kim <gi.ryoong.kim@gmail.com>
Signed-off-by: giryoong-kim <gi.ryoong.kim@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
str(session_id)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
|
Latest scan for commit: Security Scan ResultsScan Metadata
SummaryScanner ResultsThe table below shows findings by scanner, with status based on severity thresholds and dependencies: Column Explanations: Severity Levels (S/C/H/M/L/I):
Other Columns:
Scanner Results:
Severity Thresholds (Thresh Column):
Threshold Source: Values in parentheses indicate where the threshold is configured:
Statistics calculation:
Detailed FindingsShow 3 actionable findingsFinding 1: SECRET-SECRET-KEYWORD
Description: Code Snippet: Finding 2: SECRET-SECRET-KEYWORD
Description: Code Snippet: Finding 3: SECRET-SECRET-KEYWORD
Description: Code Snippet: Report generated by Automated Security Helper (ASH) at 2025年10月20日T19:53:09+00:00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also update this part please ? instead use
from bedrock_agentcore_starter_toolkit.operations.memory.manager import MemoryManager
memory_manager = MemoryManager(region_name=region)
memory = memory_manager.get_or_create_memory(name="memoryName")
memory_id = memory["id"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied the suggested change
Signed-off-by: giryoong-kim <gi.ryoong.kim@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Amazon Bedrock AgentCore Samples Pull Request
Important
review readylabel to it. Only PRs withreview readywill be reviewed.Issue number:
Concise description of the PR
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.