This repository was archived by the owner on Dec 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update aws-resource-certificatemanager-certificate.md to add the missing KeyAlgorithm Property #1311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the undocumented KeyAlgorithm Property
This PR is for this page for the AWS::CertificateManager::Certificate resource, adding a KeyAlgorithm property
Our CloudFormation resource and property reference is in sync with the AWS CloudFormation resource specification.
The Resource Spec does not have a KeyAlgorithm property for the AWS::CertificateManager::Certificate resource. If you view source on that page and search for "AWS::CertificateManager::Certificate" (including quotes) you sill see the 7 properties that are supported.
Lee,I can verify that this is in-fact fully supported (in us-east-1 at least). I’m also unclear how The link you sent is not a circular reference: GitHub backs your resource and property reference, correct?This PR is my attempt to help AWS fix a gap in documentation.Thanks,OwenOn Mar 6, 2023, at 2:02 PM, Lee Hart ***@***.***> wrote:
This PR is for this page for the AWS::CertificateManager::Certificate resource, adding a KeyAlgorithm property
Our CloudFormation resource and property reference is in sync with the AWS CloudFormation resource specification.
The Resource Spec does not have a KeyAlgorithm property for the AWS::CertificateManager::Certificate resource. If you view source on that page and search for "AWS::CertificateManager::Certificate" (including quotes) you sill see the 7 properties that are supported.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the undocumented KeyAlgorithm Property
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.