Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update Upload.ts #6833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VobileLiuZhiwu wants to merge 2 commits into aws:main
base: main
Choose a base branch
Loading
from VobileLiuZhiwu:patch-1
Open

Update Upload.ts #6833

VobileLiuZhiwu wants to merge 2 commits into aws:main from VobileLiuZhiwu:patch-1

Conversation

@VobileLiuZhiwu
Copy link

@VobileLiuZhiwu VobileLiuZhiwu commented Jan 20, 2025

I would like the lib-storage library to support the resumable upload feature. I went through the source code and found that it can be achieved by simply adding a conditional check.

Issue

Issue number, if available, prefixed with "#"

Description

What does this implement/fix? Explain your changes.

Testing

How was this change tested?

Additional context

Add any other context about the PR here.

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I would like the lib-storage library to support the resumable upload feature. I went through the source code and found that it can be achieved by simply adding a conditional check.
@VobileLiuZhiwu VobileLiuZhiwu requested a review from a team as a code owner January 20, 2025 08:05
Copy link

@sparkidea25 sparkidea25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sparkidea25 sparkidea25 sparkidea25 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /