Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add business metric support for S3 Express Bucket #6517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
S-Saranya1 wants to merge 4 commits into master
base: master
Choose a base branch
Loading
from somepal/s3-express-featureID-implementation

Conversation

@S-Saranya1
Copy link
Contributor

@S-Saranya1 S-Saranya1 commented Oct 24, 2025
edited
Loading

S3_EXPRESS_BUCKET business metric feature implementation that tracks when an operation called using the S3 Express feature.

Motivation and Context

Adding business metrics for feature IDs to track S3 Express (feature ID "J") usage in AWS SDK S3 requests. This tracks customer adoption of these S3 feature.

When the bucket name matches S3 Express Ruleset and express credentials are used, the SDK SHOULD track a business metric.

Modifications

  • Added S3ExpressUtils.addS3ExpressBusinessMetricIfApplicable() utility method that adds S3_EXPRESS_BUCKET business metric (feature ID "J") when both S3 Express endpoint resolution and S3 Express auth scheme are used.

  • Modified EndpointResolverInterceptorSpec code generation to call the S3 Express business metrics method during endpoint resolution for S3 service

Testing

  • Added functional tests to verify User-Agent header contains correct business metric when S3ExpressBucket is used.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@S-Saranya1 S-Saranya1 requested a review from a team as a code owner October 24, 2025 18:41
@S-Saranya1 S-Saranya1 changed the title (削除) Somepal/s3 express feature id implementation (削除ここまで) (追記) S3 express feature id implementation (追記ここまで) Oct 24, 2025
@S-Saranya1 S-Saranya1 changed the title (削除) S3 express feature id implementation (削除ここまで) (追記) S3Express feature id implementation (追記ここまで) Oct 24, 2025
@S-Saranya1 S-Saranya1 changed the title (削除) S3Express feature id implementation (削除ここまで) (追記) Add business metric support for S3 Express Bucket (追記ここまで) Oct 24, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
72.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /