Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update documentation to actual commands for reqs #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GabLeRoux wants to merge 1 commit into aws:master
base: master
Choose a base branch
Loading
from GabLeRoux:patch-1

Conversation

@GabLeRoux
Copy link

@GabLeRoux GabLeRoux commented Jul 9, 2020

Description of changes:

Xcode is not a valid command line for macos, this was misleading.

vbergerondev, cariacou, auranbuckles, minifisk, webb04, alouderback, allison-strandberg, shojsepter, adrienfloor, pmrotule, and justin0022 reacted with heart emoji
Xcode is not a valid command line for macos, this was misleading.
Copy link

Regarding the macOS,
For compilers to find zlib you may need to set:
export LDFLAGS="-L/usr/local/opt/zlib/lib"
export CPPFLAGS="-I/usr/local/opt/zlib/include"

GabLeRoux reacted with thumbs up emoji

Copy link

@alouderback alouderback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be merged. Recently switched to mac & didn't know about brew. Had Xcode installed, but didn't understand why the command wasn't working. This updated shell command is valid & works (tested it myself)

GabLeRoux, DarynHolmes, areibman, and adrienfloor reacted with thumbs up emoji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@webb04 webb04 webb04 approved these changes

@areibman areibman areibman approved these changes

@alouderback alouderback alouderback approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /