Fix Linux platform (specifically getBinary(), exec(), and spawn()) #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

facekapow wants to merge 2 commits into automation-stack:master

from facekapow:fix-linux

Open

Fix Linux platform (specifically getBinary(), exec(), and spawn()) #41

facekapow wants to merge 2 commits into automation-stack:master from facekapow:fix-linux

Conversation

@facekapow

Copy link

Contributor

@facekapow facekapow commented Dec 18, 2016

There was a bug in the SudoerLinux.getBinary() function which replaced the path with an object, causing [object Object] to appear as the binary path.

There was another bug in SudoerLinux.exec() and SudoerLinux.spawn() which prevented the DISPLAY variable from being set correctly if options.env isn't provided.

A (good) side effect of the fix for the exec/spawn bug is that both functions now use env just like the native Node.js equivalents (Node passes your current process.env if you don't specify the env option).

Tested and working on my machine. 👍

facekapow and others added 2 commits

December 18, 2016 18:14

@facekapow


 Fix Linux platform (specifically getBinary(), exec(), and spawn()

e09d2c1

@malept


 Fix detection of Linux sudo binary paths

73d135d

The stat utility function returns null (instead of throwing an error)
when a path is not found, so handle that case.

@malept

Copy link

malept commented Dec 31, 2016

@facekapow I found a further bug in the Linux support, which only shows up if you don't have gksudo installed. If you fast-forward merge my commit, it will fix that (the explanation of the bug is in the commit message).