This is Douyin, not Tiktok.

What's the difference? Just the name/URL or is the API completely different?

FWIW, we had a similar case with Feishu/Lark in the OpenIddict repo and decided a region option was a better approach (see openiddict/openiddict-core#2097). Since the aspnet-contrib providers developed here are a lot more expensive/time-consuming to maintain, we shouldn't duplicate the Tiktok provider if it's really the same service with just a different name and URL.

What's the difference? Just the name/URL or is the API completely different?

Looking at the documentation so far, it seems that the API URL and the response content are inconsistent.

FWIW, we had a similar case with Feishu/Lark in the OpenIddict repo and decided a region option was a better approach (see openiddict/openiddict-core#2097). Since the aspnet-contrib providers developed here are a lot more expensive/time-consuming to maintain, we shouldn't duplicate the Tiktok provider if it's really the same service with just a different name and URL.

That's a good quote. But I can't sign up for TikTok right now. I can't test TikTok.😥
Feishu, Lark, Douyin and TikTok are all ByteDance 😅

Question: If I do compatibility processing in a package, what is the name of the package?☺️

You have merge conflicts.

Sorry, I thought that the resolution of merge conflicts should be handled by the repository maintainer.
😭

Sorry, I thought that the resolution of merge conflicts should be handled by the repository maintainer. 😭

I avoid doing it as if the author wants to add extra changes and don't notice the upstream has changed sometimes they get annoyed 😄

I avoid doing it as if the author wants to add extra changes and don't notice the upstream has changed sometimes they get annoyed 😄

This taught me some important details about open source practices. Thank you!❤️

@kevinchalet Are you happy with this PR to be merged?

After re-reading #1024, I just realized that we don’t actually have a TikTok provider... it’s only been suggested that we add one: #664 😄

Anyway, my concern remains: it would be better if we had one provider - assuming the APIs are (almost) identical - that allows selecting either the China-specific service (Douyin) or the global one (TikTok).

Sadly, I don’t have a TikTok test account and last time I tried, they made creating them quite painful...

@Alex-Dobrynin @egbakou any chance you guys could help test this provider and see if it works with the global TikTok service?

Note: if we agree on having a single provider, we should probably name it TikTok so it’s easier to find.

Thanks, in that case I'll release 9.1.0 to ship the other new providers we have queued up, then this can go out in a future version.

After re-reading #1024, I just realized that we don’t actually have a TikTok provider... it’s only been suggested that we add one: #664 😄

Anyway, my concern remains: it would be better if we had one provider - assuming the APIs are (almost) identical - that allows selecting either the China-specific service (Douyin) or the global one (TikTok).

Sadly, I don’t have a TikTok test account and last time I tried, they made creating them quite painful...

@Alex-Dobrynin @egbakou any chance you guys could help test this provider and see if it works with the global TikTok service?

Note: if we agree on having a single provider, we should probably name it TikTok so it’s easier to find.

Hi @kevinchalet,
I’d love to help, but unfortunately, my TikTok app wasn’t approved, so I don’t have access to test it. Sorry :(

Hi @kevinchalet under normal circumstances, currently TikTok cannot be accessed by China users like Lark does, as this involves geopolitical influences and data security legal issues. I suggest separating TikTok and Douyin, which can enable China companies to deal with legal reviews.

Add Douyin provider

image

Screenshots translated by Microsoft
image

This is Douyin, not Tiktok.

document