-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add IonConnect library #7196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IonConnect library #7196
Conversation
Hi @vtoxi
A problem was found with your pull request:
❌ ERROR: Pull request removes newline from the end of a file.
Please add a blank line to the end of the file.
Please resolve this error. The checks will automatically run again once that is done.
More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @vtoxi. Thanks for your interest in contributing to the Arduino Library Manager.
I see the bot reported a problem with your submission that will block its acceptance:
❌ ERROR: Pull request removes newline from the end of a file.
Please add a blank line to the end of the file.
Please take prompt action to fix the problem so we can proceed with your submission. Please also make sure to carefully monitor the pull request for any additional actions that might be needed. We expect library maintainers to be conscientious about making sure to promptly complete the submission process, rather than leaving them to clutter up this very busy repository.
After that, the automated checks will run again. Once those are passing, your library will be automatically added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of a tidy repository, I'm going to close this due to lack of activity.
@vtoxi if you ever decide you are ready to dedicate the effort that is required to correctly add a single line to a text file, you can submit another pull request to add the library. Next time, prior to submitting a pull request please make sure you can reserve enough time to monitor the feedback and act promptly on any changes that are required. We expect the contributors to make the effort to complete their requests rather than leaving them in an incomplete state to clutter up this busy repository and consume finite human maintenance resources. The submission procedure is trivial, well documented, and streamlined; so this is not an unreasonable expectation.
I'll continue to monitor this thread, so feel free to let me know if you have any questions or concerns.
Adding IonConnect - Modern WiFi provisioning library for ESP32/ESP8266
Repository: https://github.com/vtoxi/IonConnect
Category: Communication
Architectures: esp32, esp8266
License: MIT
Version: 1.0.0
Features
This library provides a modern replacement for legacy WiFiManager with async operations, beautiful UI, and extensive features for production IoT devices.
Compliance