Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[PC-1197] Wordpress and Database Portenta X8 Tutorial Update #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

@Jorgetrujilloroman
Copy link
Collaborator

@Jorgetrujilloroman Jorgetrujilloroman commented Mar 23, 2023 •
edited
Loading

What This PR Changes

  • Some changes to the tutorial fixing the docker-compose.yml code and adding a download link to make it easy for the users. Adding an uninstalling section.

Contribution Guidelines

 

Some changes on the tutorial fixing the docker-compose.yml code and adding a download link to make it easy for the users. Adding an uninstalling section.
Copy link

gatsby-cloud bot commented Mar 23, 2023 •
edited
Loading

✅ docs-content deploy preview ready

 

Compressing the yml file into a rar to make it easy to download. Changing some sentences on the removing commands.
Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TaddyHC can you spend maximum 30 minutes of your time following the changes with a Portenta X8 to verify that those changes work?

We would like to be sure! :)

 

Changing some words to make it seem more formal
Small change on the section title
Copy link
Contributor

TaddyHC commented Mar 23, 2023

@TaddyHC can you spend maximum 30 minutes of your time following the changes with a Portenta X8 to verify that those changes work?

We would like to be sure! :)

@jcarolinares Sure, I'll check out the changes and post update here when possible!

Copy link
Contributor

@TaddyHC TaddyHC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jorgetrujilloroman I took the liberty of reviewing and have made a direct change to help you a bit with the process and made some reviews on top of it so you can check the reason behind the suggestion. Please have a look at it.

@jcarolinares I have tested by using the updated docker-compose.yml script of this PR and it seems to be working fine as I was able to replicate a successful result. I made some small changes to suggest to ease the tutorial walkthrough. Please let us know how you see it.

🙂

Jorgetrujilloroman and others added 4 commits March 24, 2023 09:32 
...ess-webserver/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...ess-webserver/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...ess-webserver/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
Fixing some errors on the troubleshooting section
Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes done by @Jorgetrujilloroman

Technical review done by @TaddyHC including the real testing of the tutorials

Additional changes suggested by @TaddyHC to improve the tutorial addressed by @Jorgetrujilloroman

Double-check by @jcarolinares

Ready to merge, please @Jorgetrujilloroman proceed.

cc @martab1994 FYI we have updated the tutorial to solve some small problems and a big one related with the yml file outdated and not working on the latest versions of the firmware.

@Jorgetrujilloroman Jorgetrujilloroman deleted the jorgetrujilloroman/portenta-x8/wordpress-docker-redef branch March 24, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TaddyHC TaddyHC TaddyHC left review comments

@jcarolinares jcarolinares jcarolinares approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /