-
-
Notifications
You must be signed in to change notification settings - Fork 498
[PC-1180] Portenta X8 Tutorials Banners #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ docs-content deploy preview ready
- Deploy preview
- Build logs · 3m build time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have marked some items if some alternatives fit better for the tutorial's overview. Please have a look at it 🙂
content/hardware/04.pro/boards/portenta-x8/tutorials/02.x8-fundamentals/hero-banner.png
Show resolved
Hide resolved
...hardware/04.pro/boards/portenta-x8/tutorials/04.python-arduino-data-exchange/hero-banner.png
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-x8/tutorials/06.waves-fleet-managment/hero-banner.png
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-x8/tutorials/11.display-output-webgl/hero-banner.png
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great for me, changes requested regarding the naming of some banners, waiting for that to merge
content/hardware/04.pro/boards/portenta-x8/tutorials/02.x8-fundamentals/hero-banner.png
Show resolved
Hide resolved
...hardware/04.pro/boards/portenta-x8/tutorials/04.python-arduino-data-exchange/hero-banner.png
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-x8/tutorials/06.waves-fleet-managment/hero-banner.png
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-x8/tutorials/11.display-output-webgl/hero-banner.png
Show resolved
Hide resolved
Looks great for me, changes requested regarding the naming of some banners, waiting for that to merge
Changes made in the last commit, thank you for your feedback guys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes to both
@canchebagur this is ready to merge, please proceed.
What This PR Changes
Contribution Guidelines