-
-
Notifications
You must be signed in to change notification settings - Fork 498
[GIGA Display Shield] emWin Guide #1725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs-content
🚀 Preview this PR: https://5fdaf4aa.docs-content.pages.dev
📍 Commit SHA: 4308036
@jhansson-ard
jhansson-ard
added
arduino
Bugs and fixes added by the Arduino Team
new
Tutorial
maker
labels
Feb 2, 2024
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
.../12.emwin-guide/content.md Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
@BenjaminDannegard
BenjaminDannegard
requested a review
from leonardocavagnis
February 2, 2024 10:05
karlsoderby
karlsoderby
requested changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things and suggestion before we can go live!
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
.../12.emwin-guide/content.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
.../12.emwin-guide/content.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
.../12.emwin-guide/content.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
.../12.emwin-guide/content.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
.../12.emwin-guide/content.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
.../12.emwin-guide/content.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/12.emwin-guide/content.md
Show resolved
Hide resolved
leonardocavagnis
leonardocavagnis
requested changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some hints from my side 🙂
.../12.emwin-guide/content.md Co-authored-by: Leonardo Cavagnis <45899760+leonardocavagnis@users.noreply.github.com>
.../12.emwin-guide/content.md Co-authored-by: Leonardo Cavagnis <45899760+leonardocavagnis@users.noreply.github.com>
.../12.emwin-guide/content.md Co-authored-by: Leonardo Cavagnis <45899760+leonardocavagnis@users.noreply.github.com>
.../12.emwin-guide/content.md Co-authored-by: Leonardo Cavagnis <45899760+leonardocavagnis@users.noreply.github.com>
.../12.emwin-guide/content.md Co-authored-by: Leonardo Cavagnis <45899760+leonardocavagnis@users.noreply.github.com>
.../12.emwin-guide/content.md Co-authored-by: Leonardo Cavagnis <45899760+leonardocavagnis@users.noreply.github.com>
.../12.emwin-guide/content.md Co-authored-by: Leonardo Cavagnis <45899760+leonardocavagnis@users.noreply.github.com>
karlsoderby
karlsoderby
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@BenjaminDannegard
BenjaminDannegard
requested a review
from leonardocavagnis
February 9, 2024 14:34
leonardocavagnis
leonardocavagnis
approved these changes
Feb 9, 2024
@BenjaminDannegard
BenjaminDannegard
deleted the
benjamindannegard/emwin-tutorial
branch
February 9, 2024 14:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
Contribution Guidelines