Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Swap servo images #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
avanheuvelen wants to merge 7 commits into arduino:main from avanheuvelen:hotfix/swap-servo-images
Closed

Swap servo images #1685

avanheuvelen wants to merge 7 commits into arduino:main from avanheuvelen:hotfix/swap-servo-images

Conversation

@avanheuvelen
Copy link

@avanheuvelen avanheuvelen commented Jan 21, 2024

What This PR Changes

The servo page has the images in the wrong order. The 'sweep' circuit is shown under 'knob' circuit and vice versa.

Contribution Guidelines

Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

Hello @avanheuvelen !

Thank you for your contribution!

Please revert the names of the images to their originals, but keep your change of exchanging the places of the photos. I can see you are completely right.

When you have reverted the names, and updated your PR as well as signed the CLA - we'll be able to review your PR properly.

Thank you!

@jhansson-ard jhansson-ard added fix/update A small fix or update community Bugs and fixes suggested by the community labels Jan 22, 2024
Copy link
Author

Hello @avanheuvelen !

Thank you for your contribution!

Please revert the names of the images to their originals, but keep your change of exchanging the places of the photos. I can see you are completely right.

When you have reverted the names, and updated your PR as well as signed the CLA - we'll be able to review your PR properly.

Thank you!

I've reverted the filename change for you

Copy link
Contributor

Thank you 🙏🏼

As soon as you sign the CLA we can properly review your PR ⭐

@avanheuvelen avanheuvelen closed this by deleting the head repository Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

community Bugs and fixes suggested by the community fix/update A small fix or update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /