-
-
Notifications
You must be signed in to change notification settings - Fork 498
[MKC-1036] Giga R1 WiFi add codeBlock and frontmatter board information #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ docs-content deploy preview ready
- Deploy preview
- Build logs · 12m build time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @Hannes7eicher, just fix the following error in the linter (image not used):
ERROR: Asset 'giga-file-write.png' is not used. Location: ../../content/hardware/10.mega/boards/giga-r1-wifi/tutorials/giga-usb/giga-usb.md:1:1
@jhansson-ard
jhansson-ard
added
the
infrastructure
Fixes and updates to the infrastructure of the repo
label
Aug 30, 2023
@jacobhylen
jacobhylen
deleted the
sync/Hannes7eicher/Giga-R1-WiFi-CodeBlock
branch
June 12, 2024 11:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
This PR changes the core example code snippets to use the new codeBlock component fetching the code straight from GitHub and also adds missing board information to the front matter for certain tutorials (see below).
CodeBlocks added:
Front Matter added:
Contribution Guidelines