Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[PC-1301] - Portenta C33 User Manual and Cloud IoT #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcarolinares merged 24 commits into main from canchebagur/c33-cloud-addition
Jul 4, 2023

Conversation

@canchebagur
Copy link
Contributor

@canchebagur canchebagur commented Jun 29, 2023 •
edited by jcarolinares
Loading

What This PR Changes

  • This PR adds Arduino IoT Cloud support information to the Portenta C33 user manual.

Contribution Guidelines

Copy link

gatsby-cloud bot commented Jun 29, 2023 •
edited
Loading

✅ docs-content deploy preview ready

Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested, especially the end of the section

Please avoid the overuse of "Now" :) thanks!

canchebagur and others added 10 commits July 3, 2023 13:37 
Co-authored-by: Julián Caro Linares <j.carolinares@arduino.cc>
Co-authored-by: Julián Caro Linares <j.carolinares@arduino.cc>
Co-authored-by: Julián Caro Linares <j.carolinares@arduino.cc>
Co-authored-by: Julián Caro Linares <j.carolinares@arduino.cc>
Co-authored-by: Julián Caro Linares <j.carolinares@arduino.cc>
Co-authored-by: Julián Caro Linares <j.carolinares@arduino.cc>
...ual/content.md
Julián's review
Co-authored-by: Julián Caro Linares <j.carolinares@arduino.cc>
Copy link
Contributor

@canchebagur this link is not working sorry:

image

canchebagur reacted with thumbs up emoji

Copy link
Contributor

@canchebagur solution is really simple and IMHO elegant enough:

'''
void onLedChange() {
// led variable synced with the Arduino IoT Cloud dashboard
digitalWrite(LED_BUILTIN, !led); // Portenta C33 LED is ON when pin is LOW
}
'''

Please add the ! to put a NOT on the digitalWrite
canchebagur reacted with heart emoji

Copy link
Contributor Author

@canchebagur solution is really simple and IMHO elegant enough:

''' void onLedChange() { // led variable synced with the Arduino IoT Cloud dashboard digitalWrite(LED_BUILTIN, !led); // Portenta C33 LED is ON when pin is LOW } '''

Please add the ! to put a NOT on the digitalWrite

Awesome solution, very elegant indeed.

canchebagur and others added 2 commits July 3, 2023 16:26 
Co-authored-by: Julián Caro Linares <j.carolinares@arduino.cc>
Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@canchebagur just one additional grammar suggestion

@martab1994 you can take a look and add feedback or give us a Go, thanks!!!

Copy link
Contributor

@martab1994 martab1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great, super detailed! Just few comments =)

canchebagur reacted with thumbs up emoji
canchebagur and others added 7 commits July 3, 2023 17:30 
Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
Copy link
Contributor

@martab1994 martab1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great for me =)

jcarolinares reacted with thumbs up emoji
@jcarolinares jcarolinares merged commit e13071c into main Jul 4, 2023
@jcarolinares jcarolinares deleted the canchebagur/c33-cloud-addition branch July 4, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcarolinares jcarolinares jcarolinares approved these changes

@martab1994 martab1994 martab1994 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /