Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Edit button bug fix #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcarolinares wants to merge 5 commits into main from jcarolinares/plc-ide/edit-button-fixes
Closed

Conversation

@jcarolinares
Copy link
Contributor

@jcarolinares jcarolinares commented May 30, 2023

What This PR Changes

  • Edit button bug fix

Contribution Guidelines

@jcarolinares jcarolinares requested review from GDJose and canchebagur and removed request for GDJose May 30, 2023 13:45
Copy link
Contributor

@canchebagur canchebagur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

gatsby-cloud bot commented May 30, 2023 •
edited
Loading

✅ docs-content deploy preview ready

Copy link
Contributor Author

preview even worse

now it's more broken, there are some tutorials that does not appear

Copy link
Contributor

jhansson-ard commented May 31, 2023 •
edited
Loading

@jcarolinares the links don't work, maybe you need to remove the "content" from the link?

It now points here:
image

EDIT: just saw your comment and that some tutorials are already fixed. However I don't know either why some don't show ..

@jhansson-ard jhansson-ard added bug Something isn't working arduino Bugs and fixes added by the Arduino Team labels Jun 29, 2023
Copy link
Contributor Author

Bein an unsuccesful PR I'm closing it

Copy link
Contributor

jhansson-ard commented Jul 19, 2023 •
edited
Loading

@jcarolinares thank you! should we delete the branch as well? 🌞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@canchebagur canchebagur canchebagur approved these changes

@jhansson-ard jhansson-ard Awaiting requested review from jhansson-ard

Assignees

No one assigned

Labels

arduino Bugs and fixes added by the Arduino Team bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /