-
-
Notifications
You must be signed in to change notification settings - Fork 12
Use golangci-lint instead of golint #778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
golint has been deprecated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #778 +/- ## ======================================= Coverage 90.05% 90.05% ======================================= Files 44 44 Lines 6800 6800 ======================================= Hits 6124 6124 Misses 553 553 Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codebase produces many linting errors from golangci-lint, even though it was passing golint. I think this should be put on hold until #761 is merged as the fixes for the linting errors might cause merge conflicts with the work done in that PR.
golint has been deprecated.