-
-
Notifications
You must be signed in to change notification settings - Fork 12
Add schema-based rules for pluggable monitor dependencies data of package index #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Support for a new optional `packages[*].platforms[*].monitorDependencies` field in the Arduino package index format has been added to Arduino CLI. Since the package index JSON schema does not allow additional properties in `packages[*].platforms[*]`, package indexes using this new property would previously fail validation against the schema.
There was an inefficient approach to populating the project data for package index components, where the slices were iterated over redundantly for each of the components they contained. At first perhaps a reasonable tradeoff for the sake of consistency and readability, the redundancy has became more significant over time as new components are added. With the pending addition of yet another for pluggable monitor support, it seems best to refactor now.
Codecov Report
@@ Coverage Diff @@ ## main #293 +/- ## ========================================== + Coverage 89.79% 89.95% +0.15% ========================================== Files 44 44 Lines 6626 6728 +102 ========================================== + Hits 5950 6052 +102 Misses 553 553 Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
internal/project/projectdata/testdata/packageindexes/empty-ids/package_foo_index.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small typos need to be fixed but the rest looks great. 👍
These are the JSON schema-based rules to check the `packages[].platforms[].monitorDependencies[]`-level data of the Arduino Package Index.
These are the JSON schema-based rules to check the
packages[].platforms[].monitorDependencies[]-level data of Arduino Package Index projects.