-
-
Notifications
You must be signed in to change notification settings - Fork 12
Add tests #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add tests #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@per1234
Copy link
Contributor
@per1234
per1234
commented
Dec 17, 2020
- Tests for all schema-based check functions (now possible due to Embed JSON schemas in code #105 )
- Integration tests for environment variable settings.
silvanocerza
silvanocerza
approved these changes
Dec 17, 2020
Although the previous formatting was compliant with the python:check task, it changes when the python:format task is run (due to differences between flake8 and black).
Previous to embedding the schemas in the Go code, it was not possible to write tests for these functions.
These bugs were exposed by the newly added tests.
@per1234
per1234
force-pushed
the
per1234/add-tests
branch
from
December 17, 2020 16:06
d718d3b to
69ddf97
Compare
@per1234
per1234
added
topic: infrastructure
Related to project infrastructure
type: enhancement
Proposed improvement
labels
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.