-
-
Notifications
You must be signed in to change notification settings - Fork 512
Got rid of _windows field, rely on superclass.
#952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
kittaakos
wants to merge
6
commits into
arduino:msujew/update-theia-1.24.0
from
kittaakos:window-tracking
Closed
Got rid of _windows field, rely on superclass.
#952
kittaakos
wants to merge
6
commits into
arduino:msujew/update-theia-1.24.0
from
kittaakos:window-tracking
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kittaakos
kittaakos
force-pushed
the
window-tracking
branch
from
April 11, 2022 19:29
52ab00e to
ccfae92
Compare
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
@kittaakos
kittaakos
force-pushed
the
window-tracking
branch
from
April 11, 2022 19:32
ccfae92 to
b7de377
Compare
@per1234
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Apr 11, 2022
@fstasi
fstasi
force-pushed
the
msujew/update-theia-1.24.0
branch
2 times, most recently
from
April 12, 2022 10:04
ddee44e to
8357946
Compare
@kittaakos Thanks, the changes to the ElectronMainApplication look good to me. Due to force pushes in both of our branches, I can't easily merge it, so I just adapted your changes onto my branch. Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akos Kitta kittaakos@gmail.com
Motivation
To propose changes on #947
Change description
_windowsfiled, and relies on the superclass implementation from Theia,Other information
Reviewer checklist
@msujew, this is what I meant here. Please review. Let me know if I overlooked something, I am happy to correct it. Thank you!